-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
markdown: <TOC/> component, fix #1275 [WIP] #1307
Conversation
@ulivz could you have a review on this? The original issue is marked as contribution welcome. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the great work, but I don't want to introduce so much code to fix this issue.
😢 I thought those addition could be compromised by removing a dependency. |
Another solution is that you can transform your code changes into an internal plugin, for now the code are too dispersed. |
@ulivz I added |
Breaking Changes and Migrationsslugify
format
forceFullToc
|
I'm not sure if this is relevant but before I create a new issue I'd like you guys to verify my question first: I'd like to add a I tried adding Any suggestions are highly appreciated! |
@lunaceee I think it's not our problem. https://www.meteorlxy.cn/posts/2018/11/06/koa-core-read-source-code-part-3.html You see, this is a website powered by VuePress, which indeed has a TOC on the site level, and it works well. |
Thanks @shigma, this is really helpful! |
Summary
What kind of change does this PR introduce? (check at least one)
If changing the UI of default theme, please provide the before/after screenshot:
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
fix #xxx[,#xxx]
, where "xxx" is the issue number)You have tested in the following browsers: (Providing a detailed version will be better.)
If adding a new feature, the PR's description includes:
To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.
Other information:
[[TOC]]
syntax while enable new syntax<TOC/>
. You can configurate TOC inmarkdown.toc
or by directly passing props to<TOC/>
component.slugify
,format
andforceFullToc
are not supported at present.