add feature to allow specifying language on import snippet markdown h… #1313
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR allows you to add a flag for specifying a language when using import code snippet feature. (https://vuepress.vuejs.org/guide/markdown.html#import-code-snippets)
This feature allows you to specify a language which ensures you get the proper syntax highlighting you need via prism. To specify a language, simply add
lang=<language-name>
. I ensured it is 100% backwards compatible and is flexible so ordering of lineHighlight and lang flag is irrelevant. Lang flag is also optional. Here's some examples:I updated and added the proper tests too.
If it looks good, let me know and I'll update the documentation too.
@ulivz @yyx990803
What kind of change does this PR introduce? (check at least one)
If changing the UI of default theme, please provide the before/after screenshot:
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
fix #xxx[,#xxx]
, where "xxx" is the issue number)You have tested in the following browsers: (Providing a detailed version will be better.)
If adding a new feature, the PR's description includes:
To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.
Other information: