Skip to content

fix($test): change to mocked names #1515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Conversation

shigma
Copy link
Collaborator

@shigma shigma commented Apr 3, 2019

Summary

VuePress uses a temporary workaround for jest cannot resolve module path from 'mocks' when using 'require.resolve'. However, it will break all the tests on external packages.

Example: https://circleci.com/gh/vuepress/vuepress-plugin-mathjax/5

image

In this PR, VuePress module loader will only workaround under jest and for plugins and themes that matches the following regular expression:

const MOCKED_REGEX = /^(@vuepress\/|(@[\w-]+\/)?vuepress-)(theme|plugin)-mocked-/

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

N/A

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

N/A

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

@shigma shigma requested a review from ulivz April 3, 2019 08:02
@shigma shigma changed the title $test: change to mocked names fix($test): change to mocked names Apr 3, 2019
@ulivz
Copy link
Member

ulivz commented Apr 14, 2019

Closing this in favor of: 5d2fc90

@ulivz ulivz closed this Apr 14, 2019
@shigma shigma deleted the change-to-mocked-names branch April 28, 2019 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants