Skip to content

Remove tag 'next' from installation instructions #1686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 15, 2019
Merged

Remove tag 'next' from installation instructions #1686

merged 1 commit into from
Jul 15, 2019

Conversation

mulmschneider
Copy link
Contributor

It seems to point to an older version (1.0.0-rc.1 instead of 1.0.2).

Summary

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

@kidonng
Copy link
Contributor

kidonng commented Jul 14, 2019

Hi, could you please remove them for Chinese docs as well? Thanks 😃

It seems to point to an older version (1.0.0-rc.1 instead of 1.0.2).
@mulmschneider
Copy link
Contributor Author

Hi, could you please remove them for Chinese docs as well? Thanks smiley

* https://github.com/vuejs/vuepress/blob/834010e650158831675107f5f529ce0b997b7453/packages/docs/docs/zh/guide/getting-started.md#L13

* https://github.com/vuejs/vuepress/blob/834010e650158831675107f5f529ce0b997b7453/packages/docs/docs/zh/guide/getting-started.md#L31

Thanks for the hint, I've amended the Chinese docs as well as the README.md

@ulivz ulivz merged commit 667d9f4 into vuejs:master Jul 15, 2019
@vue-bot
Copy link

vue-bot commented Jul 15, 2019

Hey @mulmschneider, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants