Skip to content

workflow: simplify changelog #1883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 23, 2019
Merged

workflow: simplify changelog #1883

merged 1 commit into from
Sep 23, 2019

Conversation

ulivz
Copy link
Member

@ulivz ulivz commented Sep 22, 2019

Summary

We don't need these fixes of feat commits which are irrelevant to actual code to appear in changelog, such as CI, documents, etc. because these do not take any effects to user's code.

IMO, these informations plus real changelog can be archived into a unified section, such as "release note"? This is worth discussing.

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

@ulivz ulivz requested review from kefranabg and flozero September 22, 2019 16:58
@flozero
Copy link
Collaborator

flozero commented Sep 22, 2019

Ok i did a very technical changelog before only but yeah definitely agree here

@ulivz ulivz merged commit b44bab3 into master Sep 23, 2019
@kefranabg kefranabg deleted the workflow/update-changelog branch November 14, 2019 11:46
@vuejs vuejs deleted a comment from ulivz Nov 14, 2019
@kefranabg
Copy link
Collaborator

Oops @ulivz I deleted your comment instead of mine 😅 Don't know how to revert it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants