Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix($docs): Uniforming VuePress labels in documentation (fixes #1998) #2005

Merged
merged 1 commit into from
Nov 8, 2019

Conversation

nimitbhargava
Copy link
Contributor

@nimitbhargava nimitbhargava commented Nov 7, 2019

Summary

fixes #1998

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

@nimitbhargava nimitbhargava changed the title docs - uniforming VuePress label docs - uniforming VuePress labels Nov 7, 2019
@nimitbhargava nimitbhargava changed the title docs - uniforming VuePress labels docs: uniforming VuePress labels Nov 7, 2019
@kefranabg kefranabg changed the title docs: uniforming VuePress labels fix($docs): Uniforming VuePress labels Nov 8, 2019
@kefranabg kefranabg changed the title fix($docs): Uniforming VuePress labels fix($docs): Uniforming VuePress labels (fixes #1998) Nov 8, 2019
@kefranabg kefranabg merged commit 6a84126 into vuejs:master Nov 8, 2019
@kefranabg kefranabg changed the title fix($docs): Uniforming VuePress labels (fixes #1998) fix($docs): Uniforming VuePress labels in documentation (fixes #1998) Nov 8, 2019
@vue-bot
Copy link

vue-bot commented Nov 8, 2019

Hey @nimitbhargava, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vuepress or VuePress in documentation?
3 participants