Skip to content

refactor(ci): use GitHub actions instead of CircleCI #2417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 25, 2020
Merged

refactor(ci): use GitHub actions instead of CircleCI #2417

merged 5 commits into from
Jul 25, 2020

Conversation

vinayakkulkarni
Copy link
Contributor

Summary

What kind of change does this PR introduce? (check at least one)

  • Build-related changes

Does this PR introduce a breaking change? (check one)

  • No

Other information:

This PR Make use of GitHub actions instead of Circle CI for building VuePress :)

@vinayakkulkarni vinayakkulkarni changed the title refactor: use GitHub actions instead of CircleCI refactor(c): use GitHub actions instead of CircleCI Jun 1, 2020
@vinayakkulkarni vinayakkulkarni changed the title refactor(c): use GitHub actions instead of CircleCI refactor(ci): use GitHub actions instead of CircleCI Jun 1, 2020
billyyyyy3320
billyyyyy3320 reviewed Jun 16, 2020
View reviewed changes
Copy link
Collaborator

@billyyyyy3320 billyyyyy3320 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you explain more detail? Why use GitHub actions instead of CircleCI?

kefranabg
kefranabg approved these changes Jul 25, 2020
View reviewed changes
Copy link
Collaborator

@kefranabg kefranabg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I just updated the file format and the cache management

@kefranabg kefranabg merged commit eb80283 into vuejs:master Jul 25, 2020
@kefranabg kefranabg mentioned this pull request Jul 25, 2020
Closed
larionov pushed a commit to larionov/vuepress that referenced this pull request Aug 19, 2020
@vinayakkulkarni @sergeylarionov-upwork
feat: use GitHub actions instead of CircleCI (vuejs#2417)
7b6e987
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@billyyyyy3320 billyyyyy3320 billyyyyy3320 left review comments

@kefranabg kefranabg kefranabg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vinayakkulkarni @kefranabg @billyyyyy3320