Skip to content

Structured and self-contained prepare #531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 31, 2018
Merged

Structured and self-contained prepare #531

merged 6 commits into from
May 31, 2018

Conversation

ulivz
Copy link
Member

@ulivz ulivz commented May 30, 2018

Summary

In order to write unit tests more conveniently, and have a clearer context to dig in the development of plugin API, the PR is to adjust the prepare from single file to the following directory structure:

└─── prepare
      ├── codegen.js
      ├── index.js
      ├── loadConfig.js 
      ├── resolveOptions.js 
      └── util.js
  • loadConfig.js: migrate from lib/util/loadConfig.js, lib/util will only contain the shared utilities.
  • util.js: methods in this util will only be used in the prepare process.

This PR also complements the UT of the prepare process's core (resolveOptions & core utilities).

@yyx990803, Hey, Evan, could you have a look at it before I merge it? Thanks!

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

@ulivz ulivz requested a review from yyx990803 May 30, 2018 16:37
@ulivz ulivz merged commit cd8ee42 into master May 31, 2018
@ulivz ulivz deleted the refactor-prepare branch June 2, 2018 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant