Skip to content

Added Scrimba lessons #1512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 21, 2019
Merged

Added Scrimba lessons #1512

merged 5 commits into from
Feb 21, 2019

Conversation

perborgen
Copy link
Contributor

@perborgen perborgen commented Feb 20, 2019 •
edited
Loading

Here are the Scrimba lessons localized and with an override.styl file for the styling. Did I do it right?

yyx990803
yyx990803 requested changes Feb 20, 2019
View reviewed changes
Copy link
Member

@yyx990803 yyx990803 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

screen shot 2019-02-20 at 4 41 34 pm

Let's give this a bit more margin at top?

@perborgen
Copy link
Contributor Author

Added a margin-top of 16 px, as that's similar to what the paragraphs have.

@yyx990803 yyx990803 merged commit 041df8d into vuejs:dev Feb 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yyx990803 yyx990803 yyx990803 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@perborgen @yyx990803