Skip to content

build: update the build system to the latest structure #1729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 27, 2020
Merged

build: update the build system to the latest structure #1729

merged 4 commits into from
Apr 27, 2020

Conversation

kiaking
Copy link
Member

@kiaking kiaking commented Apr 25, 2020

Close #1253

This PR updates the build system to align with the latest Vue libs. Almost identical to how it is in Vuex 4. The differences are:

  • Bundle name is as is.
  • UMD build instead of IIFE.

@kiaking kiaking added the build Related to the build system label Apr 25, 2020
@kiaking kiaking requested a review from ktsn April 25, 2020 16:37
@kiaking kiaking self-assigned this Apr 25, 2020
@kiaking kiaking mentioned this pull request Apr 26, 2020
Closed
@kiaking
Copy link
Member Author

kiaking commented Apr 26, 2020

Added global __DEV__ support to prevent issue #1730 from happening.

ktsn
ktsn reviewed Apr 26, 2020
View reviewed changes
ktsn
ktsn requested changes Apr 27, 2020
View reviewed changes
Copy link
Member

@ktsn ktsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the split review but I found a few issues in the build script.

ktsn
ktsn approved these changes Apr 27, 2020
View reviewed changes
Copy link
Member

@ktsn ktsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ktsn ktsn merged commit d98ea64 into dev Apr 27, 2020
@ktsn ktsn deleted the build-system branch April 27, 2020 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ktsn ktsn ktsn approved these changes

Assignees

@kiaking kiaking

Labels
build Related to the build system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kiaking @ktsn