fix(MdInput): Avoid InputEvent object from @input event #1196

VdustR · 2017-11-22T04:25:02Z

Related to Vue#6846, #7042.

After studying #7042#issuecomment-344948474, I tried:
<input type='text' v-model='model' v-bind='$attrs' 
  v-on="{
    ...$listeners,
    input: event => $emit('input', event.target.value)
  }">
and it works.

Demo: Codepen

fix #1160

marcosmoura · 2017-11-22T16:04:17Z

THAT'S AWESOME!
Can I ask you one more thing? This fix will make possible to have a non-required v-model on input, textarea, select and file.
Would you mind to improve this too?

VdustR · 2017-11-22T17:00:03Z

I'll do my best.

VdustR · 2017-11-23T01:43:38Z

@marcosmoura Excuse me. How to resolve netlify deploy preview failed?

I checked the details and it showed page not found to me.

…MdSelect.modelValue` synced wit

…dTextarea optional `MdSelect` could be switched between single and multiple fix #1150

VdustR · 2017-11-23T05:37:09Z

fix(MdField): $emit missing this
fix(MdSelect): declare all MdSelect properties in data() and make MdSelect.modelValue synced with model
feat(MdField): make 'v-model'/'value' in MdFile, MdInput, MdSelect, MdTextarea optional
- Related to [md-select] Make v-model optional #1150
- MdSelect could be switched between single and multiple
feat(MdSelect): one direction update with :value

fix #1203

VdustR · 2017-11-23T06:14:45Z

fix(MdOption): let value avaiable to be 0
- fix MdSelect integer 0 as Value is not working #1203

marcosmoura · 2017-11-23T18:06:54Z

src/components/MdField/MdFieldMixin.js

@@ -1,7 +1,7 @@
 export default {
  props: {
    value: {
-      required: true
+      default: null


I think a better approach to this is value: {}
This will allow any type.

marcosmoura · 2017-11-23T18:09:57Z

src/components/MdField/MdSelect/MdSelect.vue

        this.setFieldValue()
      },
      setMultipleContentByValue () {
+        if (!this.localValue) this.initialLocalValueByDefault()


To improve code style, change this if to be inside brackets:
if ( ... ) {
...
}

marcosmoura

Awesome work!
Just some minor issues with code style

#1196 (comment)

@input

* origin/dev: docs: add note for themes, example with CDNs (#1225) fix(MdProgressSpinner): fix firefox radius (#1221) fix(MdDatepicker): show today if date is not selected (#1214) fix(MdInput): avoid InputEvent object from @input event (#1196) docs: change old repository name to new (#1216) fix(MdAutocomplete): sync v-model with search term (#1218) chore: add codesponsor again Update README.md Revert "fix(MdChips): make chip allow spaces (#1211)" Revert "fix: remove global scoped css affecting all md-content elements" chore: remove codesponsor because github is a bad guy! chore: remove codesponsor because github is a bad guy! fix: remove global scoped css affecting all md-content elements chore: remove async attribute fix(MdChips): make chip allow spaces (#1211) docs(Codepen): Fix codepen style undefined (#1202) Updated file doc. Typo in event name md-change (#1192) Revert "build: generate beta 5" docs: improve drastically the initial load of documentation

@input

* fix(MdInput): Avoid InputEvent object from @input event fix #1160 * fix(MdField): `$emit` missing `this` * fix(MdSelect): declare all MdSelect properties in `data()` and make `MdSelect.modelValue` synced wit * feat(MdField): make 'v-model'/'value' in MdFile, MdInput, MdSelect, MdTextarea optional `MdSelect` could be switched between single and multiple fix #1150 * feat(MdSelect): one way update with `value` * fix(MdOption): let value avaiable to be `0` fix #1203 * fix(MdField): set value default as null * fix(MdField): Remove value default vuematerial/vue-material#1196 (comment) * style(MdSelect): brackets for if statement execute block vuematerial/vue-material#1196 (comment)

@input

* fix(MdInput): Avoid InputEvent object from @input event fix #1160 * fix(MdField): `$emit` missing `this` * fix(MdSelect): declare all MdSelect properties in `data()` and make `MdSelect.modelValue` synced wit * feat(MdField): make 'v-model'/'value' in MdFile, MdInput, MdSelect, MdTextarea optional `MdSelect` could be switched between single and multiple fix #1150 * feat(MdSelect): one way update with `value` * fix(MdOption): let value avaiable to be `0` fix #1203 * fix(MdField): set value default as null * fix(MdField): Remove value default vuematerial/vue-material#1196 (comment) * style(MdSelect): brackets for if statement execute block vuematerial/vue-material#1196 (comment)

fix(MdInput): Avoid InputEvent object from @input event

6fedf74

fix #1160

marcosmoura self-requested a review November 22, 2017 16:04

fix(MdField): $emit missing this

20cb2c4

VdustR added 3 commits November 23, 2017 09:54

fix(MdSelect): declare all MdSelect properties in data() and make `…

3afac36

…MdSelect.modelValue` synced wit

feat(MdField): make 'v-model'/'value' in MdFile, MdInput, MdSelect, M…

49eca2a

…dTextarea optional `MdSelect` could be switched between single and multiple fix #1150

feat(MdSelect): one way update with value

df0c09b

fix(MdOption): let value avaiable to be 0

7777cc5

fix #1203

fix(MdField): set value default as null

dac187b

marcosmoura reviewed Nov 23, 2017

View reviewed changes

marcosmoura approved these changes Nov 23, 2017

View reviewed changes

marcosmoura reviewed Nov 23, 2017

View reviewed changes

marcosmoura requested changes Nov 23, 2017

View reviewed changes

VdustR added 2 commits November 24, 2017 08:20

fix(MdField): Remove value default

eee12f4

#1196 (comment)

style(MdSelect): brackets for if statement execute block

bb614c1

#1196 (comment)

marcosmoura approved these changes Nov 27, 2017

View reviewed changes

marcosmoura merged commit 12a4219 into vuematerial:dev Nov 27, 2017

VdustR deleted the fix#1160 branch November 29, 2017 03:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix(MdInput): Avoid InputEvent object from @input event #1196

fix(MdInput): Avoid InputEvent object from @input event #1196

Uh oh!

VdustR commented Nov 22, 2017

Uh oh!

marcosmoura commented Nov 22, 2017

Uh oh!

VdustR commented Nov 22, 2017

Uh oh!

VdustR commented Nov 23, 2017 •

edited

Loading

Uh oh!

VdustR commented Nov 23, 2017 •

edited

Loading

Uh oh!

VdustR commented Nov 23, 2017

Uh oh!

marcosmoura Nov 23, 2017 •

edited

Loading

Uh oh!

marcosmoura Nov 23, 2017 •

edited

Loading

Uh oh!

marcosmoura left a comment

Uh oh!

Uh oh!

Uh oh!

fix(MdInput): Avoid InputEvent object from @input event #1196

fix(MdInput): Avoid InputEvent object from @input event #1196

Uh oh!

Conversation

VdustR commented Nov 22, 2017

Uh oh!

marcosmoura commented Nov 22, 2017

Uh oh!

VdustR commented Nov 22, 2017

Uh oh!

VdustR commented Nov 23, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

VdustR commented Nov 23, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

VdustR commented Nov 23, 2017

Uh oh!

marcosmoura Nov 23, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

marcosmoura Nov 23, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

marcosmoura left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

VdustR commented Nov 23, 2017 •

edited

Loading

VdustR commented Nov 23, 2017 •

edited

Loading

marcosmoura Nov 23, 2017 •

edited

Loading

marcosmoura Nov 23, 2017 •

edited

Loading