Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support async function exported in vuepress config #1376

Closed
wants to merge 2 commits into from

Conversation

dz85
Copy link

@dz85 dz85 commented Jul 5, 2023

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Provide a description in this PR that addresses what the PR is solving. If this PR is going to solve an existing issue, please reference the issue (e.g. close #123).

What is the purpose of this pull request?

  • Bug fix
  • New feature
  • Documentation update
  • Other

Description

support both function form and async function form when using vuepress config file with both vuepress dev and vuepress build.

more about this:

Screenshots

Before

After

@Mister-Hope
Copy link
Member

Can't you write top level await directly? E.g.:

const options = await getOptions()

export default options

So what does your pr actually solves?

Copy link
Member

@Mister-Hope Mister-Hope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any necessity of this pr, please explain.

@meteorlxy
Copy link
Member

Closing per this

@meteorlxy meteorlxy closed this Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants