Skip to content
This repository was archived by the owner on May 13, 2024. It is now read-only.

fix: Pagination Number in Nav Change is unchanged #21

Merged
merged 2 commits into from
Sep 9, 2019

Conversation

tolking
Copy link
Contributor

@tolking tolking commented Aug 24, 2019

Summary

Fix Pagination Number in Nav Change is unchanged
ulivz.com from 编程 page/2 to 文集 pagination number is 2

What kind of change does this PR introduce? (check at least one)

  • [ X] Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • [ X] No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • [ X] Chrome
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

Copy link
Member

@billyyyyy3320 billyyyyy3320 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this bug.

But it can be better to use computed and simply pass the value to the child component instead of v-model.

@tolking
Copy link
Contributor Author

tolking commented Sep 9, 2019

Thanks for fixing this bug.

But it can be better to use computed and simply pass the value to the child component instead of v-model.

Thanks, that's a good idea.

@billyyyyy3320
Copy link
Member

LGTM

@billyyyyy3320 billyyyyy3320 merged commit 6fae794 into vuepress:master Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants