This repository was archived by the owner on Jun 11, 2024. It is now read-only.
Fix / attributes_metadata contains too many attributes #384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
didkan
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #383
When collecting attributes to populate
attributes_metadataalmost ALL attributes were fetched creating a lot of data to be transferred to ElasticSearch. I changed the the logic so only the attributes that haveis_visibleANDis_visible_on_frontset will be collected.I assume this was intent from the beginning.
Probably we can even get rid of the
is_visiblecheck and only fetch attributes based onis_visible_on_front.I think an attribute will never have
is_visible == 0andis_visible_on_front == 1at the same time?!What do you think @afirlejczyk @doliwa-divante ?