Add webpack 5 support

[bloodlit]

No description provided.

[devsuitup]

Thank you so much dude !

[icleolion]

Seeing as this loader doesn't claim to support webpack 3 I would take this PR over #158

[bloodlit]

Seeing as this loader doesn't claim to support webpack 3 I would take this PR over #158

// webpack4 and lower
VuetifyLoaderPlugin = require('./plugin-webpack4')

If earlier Webpack 3 was provided, then it will work.

[hmnd]

Seeing as this loader doesn't claim to support webpack 3 I would take this PR over #158

// webpack4 and lower
VuetifyLoaderPlugin = require('./plugin-webpack4')

If earlier Webpack 3 was provided, then it will work.

Your PR is basically a duplicate of #158 though. Why open a new one?

[icleolion]

Suggested change

	attrsMatch: this.options.attrsMatch || []
	attrsMatch: this.options.attrsMatch || [],
	registerStylesSSR: this.options.registerStylesSSR || false

Is registerStylesSSR deliberately not included in the webpack5 version or was this an oversight?

[bloodlit]

oversight

[icleolion]

@hmnd There are a handful of differences so if @bloodlit feels his attempt is better than #158 then why not raise a new PR.

@bloodlit my point about webpack 3 support is based on vue-loader/commit/745d054. They had to beef up that if check to support webpack 3 for some reason. But vue-loader lists webpack 3 as one of it's peerDependencies, whereas vuetify-loader does not, so that extra check included in #158 is a waste of bytes.

Speaking of peerDependencies , neither this PR nor #158 update the peerDependencies to include support for webpack 5.

Also, there has been a number of developments to webpack 5 that vue-loader has had to keep up with. I'm assuming vue-loader's implementation inspired this PR just like it did with #158, so do any of the below commits inspire further development on this PR to better support webpack 5?

1. feat: support Rule.rules (nested rules) (#1618)
2. fix: ensure unique ident when cloning rules, fix webpack 5 compatibility (#1653)
3. fix: skip matching rule with 'enforce'
4. fix: ensure new webpack5 generator property in rules passes ruleset checks (#1753)
5. fix: add rule plugins to keep up with webpack 5 new features

[petrprikryl]

Hi, I am trying this PR on my project and have problem with styles order in development. My custom styles are being overriden by Vuetify styles:

.v-select styles should be ignored as it should be loaded before my custom .catalogue__sort. Problem seems to be with inline style blocks ordering in dev mode. Very strange is that this is not happening after bundling and serving plain css without dev server.

Next I tried to import whole vuetify/dist/vuetify.min.css and disable vuetify-loader and this problem wasn't happening. So I am suspecting that the problem is here. Because I wasn't facing it with Webpack 4 and offical version 1.6.0 of vuetify-loader.

Can anybody push me the right way where the problem is?

[deleonio]

I checked this PR - It build, but there a lot of errors in SASS.

---

the same story here:

• webpack 5 support #136 and here
• Webpack5 does not build anymore aurelia/aurelia#982 and here
• Update VirtualModulesPlugin from upstream sveltejs/svelte-loader#136 and so on

Many thanks to Angular for influencing Webpack and the unconsolidated upgrade to v5.

[DRoet]

Checked this PR now that @vue/cli-service": "5.0.0-alpha.0 is out, but it indeed throws a lot of SASS errors

[KaelWD]

Yeah I have my own implementation in progress that works with progressiveImages and has less code duplication. Thanks for the effort but it doesn't really cut it.