Adds --useVscode flag to override location of .vscode/settings.json #112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ettings.json configuration
- use cross-spawn to invoke tslint, since it's a .cmd on Windows - manually invoke `node` when running tsfmt since Windows doesn't natively support hashbangs - normalize process.cwd() to unix path separators when comparing against other paths - add .gitattributes that prevents automatic eol changes since some test cases require CRLF, some require LF
|
I'm partially merged this PR in 9e285b4 I will checking |
|
The extra dependency is only for development, not runtime, so it will not affect users. You can of course implement the necessary Windows spawning yourself, but that sounds like extra effort without any real benefit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #109
I also had to tweak the test cases to run on Windows. Spawning tslint, for example, is a bit different on Windows since npm generates a .cmd shim for package binaries on Windows.