Amqp interop based version.

[makasim]

ref #153

This is far from the final version, the aim of this PR is to show differences in approaches.

[vyuldashev]

I like the approach, I guess we can use it in v6.0. Does enqueue support SSL connections?

[makasim]

Does enqueue support SSL connections?

Not yet, I am going to work on it before continue with this PR

[makasim]

now Enqueue supports secure connections: php-enqueue/enqueue-dev#246

[vyuldashev]

Nice, so I wait for your pull request to be complete.

[makasim]

The code was tested manually in a sandbox app. More or less working.

Can I use phpunit built-in mocker in the tests?

[vyuldashev]

@makasim It's better to use real rabbitmq instance in tests.

[makasim]

@makasim It's better to use real rabbitmq instance in tests.

I don't understand. Would you like to have functional tests that interact with a real RabbitMQ broker?

[vyuldashev]

@makasim It would be awesome.

[makasim]

I am fine with writing them though I don't think it worth it. Enqueue transports have a lot of functional tests.

[makasim]

@vyuldashev ready for review. There is one failing test (ssl connection). I am going to fix it tomorrow beside that everything else is ready.

[makasim]

@vyuldashev All is green and ready for review

[makasim]

@vyuldashev When will you have time to review?

[vyuldashev]

@makasim Is it already ready? I see tests are failing. Did you test this version on a Laravel app?

[makasim]

@vyuldashev yes it is ready, tests failed because of the latest fix. I'll fix them asap.

I tested several flows here php-enqueue/enqueue-sandbox#9

[makasim]

I'll be able to provide support in case of issues after merging it. I'll keep an eye on issues and comment or you can ping me

[vyuldashev]

@makasim I merged your PR, thanks. But before releasing I want to make some changes.

[vyuldashev]

@makasim This version is available as dev-master / 6.0.x-dev for now.

[vrubiella]

@makasim I'm sorry for breaking the tests, I see you fixed now. 👍

[makasim]

@vrubiella np

[makasim]

@vyuldashev is there any ETA for rolling 6.0 release?

[vyuldashev]

@makasim Next week I will have a look and make a release.

[makasim]

@vyuldashev are there any news on the release? thanks

[vyuldashev]

@makasim sorry was very busy. Let’s release it tonight. Did you test 6.0-dev? Does it work as expected with new configuration and amqp-interop?

[makasim]

works for us.

[vyuldashev]

Released.