Added scopes, endpoint security and errors #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

mkhraisha merged 19 commits into main from 124-need-to-define-scopes-or-roles

May 3, 2022

Collaborator

nissimsan commented Apr 20, 2022

Added scopes from Need to define scopes or roles #124
Assigned to endpoints
Added 401 and 403 errors


          feat: scopes and security

nissimsan requested review from OR13, mprorock and mkhraisha as code owners

April 20, 2022 09:50

nissimsan linked an issue

that may be closed by this pull request

Need to define scopes or roles #124

Closed

nissimsan mentioned this pull request

Better error handling #41

Closed

BenjaminMoe reviewed

View reviewed changes

docs/openapi/openapi.yml Outdated Show resolved Hide resolved

OR13 approved these changes

View reviewed changes

mprorock approved these changes

View reviewed changes


          fix: missed errors for cred issuer

f2c6605

BenjaminMoe suggested changes

View reviewed changes

Contributor

BenjaminMoe left a comment •

edited

Loading

I think trying to be a cool kid and abbreviating vc and vp is going to hurt us in the long run. The main reason to abbreviate is to save space, we should focus on clarity.

create:vc -> create:credential
verify:vc -> verify:credential
read:vc -> read:credential
update:vc -> update:credential
create:vp -> create:presentation
verify:vp -> verify:presentation
exchange:vp -> exchange:presentation

BenjaminMoe reviewed

View reviewed changes

docs/openapi/openapi.yml Outdated Show resolved Hide resolved

BenjaminMoe reviewed

View reviewed changes

docs/openapi/openapi.yml Outdated Show resolved Hide resolved

BenjaminMoe reviewed

View reviewed changes

docs/openapi/openapi.yml Outdated Show resolved Hide resolved

BenjaminMoe reviewed

View reviewed changes

docs/openapi/openapi.yml Outdated Show resolved Hide resolved

BenjaminMoe reviewed

View reviewed changes

docs/openapi/openapi.yml Outdated Show resolved Hide resolved

BenjaminMoe reviewed

View reviewed changes

docs/openapi/openapi.yml Outdated Show resolved Hide resolved

BenjaminMoe reviewed

View reviewed changes

docs/openapi/openapi.yml Outdated Show resolved Hide resolved

BenjaminMoe reviewed

View reviewed changes

docs/openapi/resources/credential-issuer.yml Outdated Show resolved Hide resolved

BenjaminMoe reviewed

View reviewed changes

docs/openapi/resources/credential-status.yml Outdated Show resolved Hide resolved

BenjaminMoe reviewed

View reviewed changes

docs/openapi/resources/credential-verifier.yml Outdated Show resolved Hide resolved

BenjaminMoe reviewed

View reviewed changes

docs/openapi/resources/credential.yml Outdated Show resolved Hide resolved

BenjaminMoe reviewed

View reviewed changes

docs/openapi/resources/presentation-prover.yml Outdated Show resolved Hide resolved

BenjaminMoe reviewed

View reviewed changes

docs/openapi/resources/presentation-verifier.yml Outdated Show resolved Hide resolved

BenjaminMoe reviewed

View reviewed changes

docs/openapi/resources/presentations.yml Outdated Show resolved Hide resolved

nissimsan and others added 5 commits

May 3, 2022 10:21


          Update docs/openapi/openapi.yml

a72664c

Co-authored-by: Benjamin Collins <[email protected]>


          Update docs/openapi/openapi.yml

e221a59

Co-authored-by: Benjamin Collins <[email protected]>


          Update docs/openapi/openapi.yml

bc2d100

Co-authored-by: Benjamin Collins <[email protected]>


          Update docs/openapi/openapi.yml

e1ae274

Co-authored-by: Benjamin Collins <[email protected]>


          Update docs/openapi/openapi.yml

0bb8786

Co-authored-by: Benjamin Collins <[email protected]>

nissimsan and others added 9 commits

May 3, 2022 10:22


          Update docs/openapi/openapi.yml

c95fc23

Co-authored-by: Benjamin Collins <[email protected]>


          Update docs/openapi/openapi.yml

dc2702d

Co-authored-by: Benjamin Collins <[email protected]>


          Update docs/openapi/resources/credential-issuer.yml

b6da500

Co-authored-by: Benjamin Collins <[email protected]>


          Update docs/openapi/resources/credential-status.yml

1f1a5d3

Co-authored-by: Benjamin Collins <[email protected]>


          Update docs/openapi/resources/credential-verifier.yml

485e941

Co-authored-by: Benjamin Collins <[email protected]>


          Update docs/openapi/resources/credential.yml

62d9f6d

Co-authored-by: Benjamin Collins <[email protected]>


          Update docs/openapi/resources/presentation-prover.yml

53ad53f

Co-authored-by: Benjamin Collins <[email protected]>


          Update docs/openapi/resources/presentation-verifier.yml

5ad7c68

Co-authored-by: Benjamin Collins <[email protected]>


          Update docs/openapi/resources/presentations.yml

25546d3

Co-authored-by: Benjamin Collins <[email protected]>

BenjaminMoe approved these changes

View reviewed changes

Nis Jespersen added 3 commits

May 3, 2022 10:30


          feat: changing scope names to plural

e63b7f1


          feat: issue and prove scope names

47ed03b


          chore: submit vp description

e0c772f

OR13 approved these changes

View reviewed changes

mkhraisha approved these changes

View reviewed changes

mkhraisha merged commit 26bd114 into main

nissimsan mentioned this pull request

Test case should be added for oauth presentation exchange #211

Closed

nissimsan deleted the 124-need-to-define-scopes-or-roles branch

May 3, 2022 18:43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet