-
Notifications
You must be signed in to change notification settings - Fork 318
Switch useCache to an enum #1104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Gecko bug to avoid shipping boolean useCache: https://bugzilla.mozilla.org/show_bug.cgi?id=1353638 Gecko bug to switch to enum: https://bugzilla.mozilla.org/show_bug.cgi?id=1353636 |
I'm worried it isn't clear that |
Service worker spec PR #1107 |
Just to clarify, is this also doing FB's request to bypass cache on register? The new name just made me wonder. |
Nah, I haven't added that. But you're right, the naming makes even more sense considering that. |
This is part of w3c/ServiceWorker#1104
PR: #1107 |
This is part of w3c/ServiceWorker#1104
This is part of w3c/ServiceWorker#1104.
Changing useCache boolean to updateViaCache enum Issue: #1104. Tests: web-platform-tests/wpt#5515. HTML change: whatwg/html@b5fcec0.
SW change: c92c148. (merged) |
We're confused that the service worker spec and the HTML spec seem to have contradicting definitions of updateViaCache in HTMLLinkElement.
(HTML spec)
It seems the HTMLLinkElement extension in the service worker spec is not needed since the HTML spec has it. |
Ahh yes, we need to remove the one from the service worker spec. The HTML spec is the correct one. |
Yes, it's being addressed in #1110 (comment). |
Tests landed web-platform-tests/wpt#5515 |
This is part of w3c/ServiceWorker#1104.
We're worried about fetch all
importScripts
on every navigation. It sounds really heavy and a waste of bandwidth.New proposal.
useCache
values:It's a bit late in the day, but we all think this is a much safer change.
The text was updated successfully, but these errors were encountered: