Fix for each iterations referring to infra #578
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annevk
reviewed
Nov 25, 2022
|
@domenic it seems "process a navigate fetch" changed and breaks CI. @antosart seems there's also some tab-vs-space issues in the source per CI and the w3c/spec-prod might be outdated? cc @sideshowbarker |
|
I can fix the tab-vs-space issues but they are not blocking. The broken references are. It looks like there are more of them, but I am not sure how to solve the browsing context ones (cf. #579). |
antosart
force-pushed
the
fix-for-each
branch
from
2e6f15d to
cb65604
Compare
antosart
force-pushed
the
fix-for-each
branch
from
cb65604 to
13f4f10
Compare
github-actions bot
added a commit
that referenced
this pull request
Dec 1, 2022
SHA: 1f4904f Reason: push, by antosart Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix iteration over directive's value, which is an ordered set (Fixes #577).
Add proper references to infra for all "for each" iterations.
Fix iteration over element's attribute list.