-
-
Notifications
You must be signed in to change notification settings - Fork 64
feat: support constructor as a member #300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
test/syntax/idl/constructor.widl
Outdated
interface Circle { | ||
constructor(); | ||
constructor(float radius); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wonder if we should add our own cases too with other argument things... probably not necessary given everything uses the same code path.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
..e.g. variadic, optional, defaults, etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's not strictly needed but also does not harm. I'll add them as it's simple enough.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great... though should we sit on this till the WebIDL side merges?
whatwg/webidl#700 (review) says the vise-versa thing, wouldn't it be a deadlock? I'm not sure. |
Ok, I think we should let them know we are ready on our side. We are a small piece of the solution: getting Gecko, Blink, etc. to update their binding layers will take some time. We could also add ReSpec support, which will also help move things along a little. |
Should be merged only when we are confident that browser implementors are on board. |
Yay! Looks like this can finally land... we should make a plan for what to do about specs that are using the old syntax. |
We can add an autofix, but I feel like I should wait until at least some of the spec actually start to use the new syntax. |
I'd like to use it for PaymentRequest :) |
For whatwg/webidl#700.