File Persistence and MongoDB persistence #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibek
approved these changes
Mar 17, 2025
orpiske
requested changes
Mar 17, 2025
There was a problem hiding this comment.
Overall, it looks good to me and I think you are on the right track.
There's a few improvements I think we could have on the code:
- try to add javadoc to the core persistence api
- I'd prefer if we named it
core-persistence-file,core-persistence-apiandcore-persistence-mongodb: the reason being that as we add more and more components for the code, it starts to get a bit confusing to navigate in the project tree. - Make sure to add the MongoDB container (or Postgres) in the
docker-compose.ymlfile. - Also make sure to add documentation about this on the usage guide.
Thanks!
Croway
force-pushed
the
core-persistence
branch
4 times, most recently
from
0fa438d to
db71d70
Compare
orpiske
requested changes
Mar 18, 2025
core/core-service-discovery/src/main/java/ai/wanaku/core/service/discovery/ValkeyRegistry.java
Show resolved
Hide resolved
...-service-discovery/src/main/java/ai/wanaku/core/service/discovery/WanakuServiceRegistry.java
Outdated
Show resolved
Hide resolved
routers/wanaku-router/src/main/resources/application.properties
Outdated
Show resolved
Hide resolved
...er-quarkus/src/main/java/ai/wanaku/server/quarkus/api/v1/management/targets/TargetsBean.java
Outdated
Show resolved
Hide resolved
...er-quarkus/src/main/java/ai/wanaku/server/quarkus/api/v1/management/targets/TargetsBean.java
Outdated
Show resolved
Hide resolved
services/tools/wanaku-routing-yaml-route-service/src/main/resources/application.properties
Outdated
Show resolved
Hide resolved
orpiske
reviewed
Mar 24, 2025
servers/wanaku-server-quarkus/src/main/resources/application.properties
Outdated
Show resolved
Hide resolved
...s/wanaku-server-quarkus/src/test/java/org/wanaku/server/quarkus/support/TestIndexHelper.java
Show resolved
Hide resolved
Comment on lines
33
to
36
|
|
||
| #quarkus.mongodb.connection-string = mongodb://localhost:27017 | ||
| #wanaku.persistence.mongodb = true |
There was a problem hiding this comment.
I guess this is out of scope, as downstream services should not interact w/ the persistence layer.
|
Per discussion, this should also resolve #190. |
orpiske
approved these changes
Mar 24, 2025
rename persistence modules Use repository in wanaku server File Persistence and MongoDB persistence Use repository in wanaku server rebase main fix Resources test
Croway
force-pushed
the
core-persistence
branch
from
5a41eee to
f8a7be5
Compare
Croway
force-pushed
the
core-persistence
branch
from
f8a7be5 to
3fdf159
Compare
This was
linked to
issues
Mar 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Persistence core module, at the moment 2 persistence flavour are implemented:
wanaku.persistence.mongodbis set totrue