Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement respond_to_missing? #9

Merged
merged 3 commits into from
May 14, 2019
Merged

Implement respond_to_missing? #9

merged 3 commits into from
May 14, 2019

Conversation

irxground
Copy link
Contributor

Ruby uses the respond_to? method to check if a certain method exists. If method_missing is implemented, respond_to_missing? should also be implemented.

Hywan
Hywan suggested changes May 14, 2019
View reviewed changes
Copy link
Contributor

@Hywan Hywan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a small note!

@Hywan
Copy link
Contributor

Hywan commented May 14, 2019

Thanks for the PR :-)!

@Hywan
Copy link
Contributor

Hywan commented May 14, 2019

bors try

bors bot added a commit that referenced this pull request May 14, 2019
@bors
Try #9:
93526bc
@bors
Copy link
Contributor

bors bot commented May 14, 2019

try

Build succeeded

@Hywan Hywan self-assigned this May 14, 2019
@Hywan Hywan added 🎉 enhancement New feature or request 📦 component-extension About the Ruby extension written in Rust 🧪 tests I love tests labels May 14, 2019
@Hywan Hywan merged commit 30f8bbb into wasmerio:master May 14, 2019
@Hywan
Copy link
Contributor

Hywan commented May 14, 2019

Merged, thank you!

@irxground irxground deleted the respond_to_missing branch May 15, 2019 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hywan Hywan Hywan requested changes

Assignees

@Hywan Hywan

Labels
📦 component-extension About the Ruby extension written in Rust 🎉 enhancement New feature or request 🧪 tests I love tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@irxground @Hywan