Skip to content

Add fpm package manifest #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 5, 2020
Merged

Add fpm package manifest #18

merged 4 commits into from
Oct 5, 2020

Conversation

awvwgk
Copy link
Contributor

@awvwgk awvwgk commented Oct 5, 2020

  • support usage of functional-fortran with fpm
  • does not support testing due to shortcomings of bootstrap fpm

Fixes #17

- support usage of functional-fortran with fpm
- does not support testing due to shortcomings of bootstrap fpm
@milancurcic
Copy link
Member

Thanks a lot @awvwgk. Did you check that fpm build works?

@awvwgk
Copy link
Contributor Author

awvwgk commented Oct 5, 2020

Of course, checked with bootstrap fpm and GCC 10.2.

@milancurcic
Copy link
Member

Great, thank you.

One more thing: I think the package name should be just "functional". Rationale: The repo name "functional-fortran", like with "datetime-fortran" was a branding decision. It allowed it to stand out, and, putting words "functional" and "Fortran" together helped it get attention. However, in the context of fpm and Fortran packages, the word "fortran" is redundant.

I did the same with datetime-fortran, which as an fpm package is just datetime.

What do you think?

- match datetime-fortran's fpm.toml
@milancurcic
Copy link
Member

Thank you!

@milancurcic milancurcic merged commit 3af0e6d into wavebitscientific:master Oct 5, 2020
@certik
Copy link

certik commented Oct 5, 2020

Yes, the name should be just datetime and functional.

@awvwgk awvwgk deleted the fpm-support branch October 5, 2020 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

functional-fortran as an fpm package
3 participants