refactor: supersede entry query by entry dedicated loader #896
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fi3ework
force-pushed
the
remove-entry-query
branch
from
caba130 to
213dd67
Compare
✅ Deploy Preview for rslib ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
fi3ework
force-pushed
the
remove-entry-query
branch
from
213dd67 to
22a9356
Compare
Timeless0911
reviewed
Apr 3, 2025
|
This PR turns out doesn't resolve multiple entry modules issue which behaves the same as entry query solution when entry module is circular dependented. But this's way better than entry query solution. |
Timeless0911
approved these changes
Apr 3, 2025
|
#316 is still not resolved in fact (just workaround for now). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Remove query entry, it's hack and may raise other unexpected issues. Supersede it with an entry dedicated loader, which will only executed for entry module.
Related Links
Checklist