Skip to content
This repository was archived by the owner on Mar 5, 2025. It is now read-only.

"undefined" resolves as an error #2

Closed
obscuren opened this issue Oct 31, 2014 · 1 comment
Closed

"undefined" resolves as an error #2

obscuren opened this issue Oct 31, 2014 · 1 comment

Comments

@obscuren
Copy link
Contributor

This shouldn't result in an error. It's perfectly fine to return "undefined" from eth.transaction(num, i) for example

@debris
Copy link
Contributor

debris commented Nov 21, 2014

this bug is no longer present

greg-flexidao added a commit to greg-flexidao/web3.js that referenced this issue Sep 13, 2018
Not fulfilling the promise/callback in the certain circumstances.
greg-flexidao added a commit to greg-flexidao/web3.js that referenced this issue Sep 13, 2018
Causing endless wait for for tx receipt/hash
nivida pushed a commit that referenced this issue Apr 23, 2019
Update web3-eth-admin.rst
nachomazzara pushed a commit to nachomazzara/web3.js that referenced this issue Jun 4, 2020
spacesailor24 added a commit that referenced this issue Jul 19, 2021
* Add additional EIP-2930 and EIP-1559 tests

* Update gasPrice to geth default minimum

* Replace hex number with number string

* Add test skip if using Ganache

* Add done function to ganache skip

* Add done function to ganache skip

* Update gasPrice params

* Bump gasPrice to Geth default

* Bump docker geth version to stable

* Gas price type number for 1 Gwei

* gasPrice type and backfills timeout change

* gasPrice type and test acct creation

* added nonce for geth auto nonce issue, removed auto acct creation

* Remove redundant London test. Add gasLimit field to London test

* Add validation for tx.maxPriorityFeePerGas and tx.maxFeePerGas

* Add additional 1559 tests

Co-authored-by: jdevcs <[email protected]>
Co-authored-by: jdevcs <[email protected]>
spacesailor24 added a commit that referenced this issue Jul 21, 2021
* npm run build for 1.4.0-rc.0

* v1.4.0-rc.0

* Update scripts/e2e.geth.instamine.sh to use v1.10.3 of Geth

* Update scripts/e2e.geth.instamine.sh to use v1.10.3 of Geth

* Fix typo

* WIP

* Fix type in error catch

Co-authored-by: Gregory Markou <[email protected]>

* Remove commented code

* Update index for tx pricing info

* Correct order of if statements to properly assign tx type

* Update maxFeePerGas calculation

* Init _handleTxType function

* Update _handleTxPricing to use gasPrice for eip-1559 txs

* Fix bugs in _handleTxPricing

* Update tests for eip-1559 changes

* Fix BN bug: .mul only accepts BN instances

* eth.accounts.signTransaction: Add London tests

* Add EIP-1559 test without AccessList

* Add tx.common.hardfork check to _handleTxType

* Bug fixes

* Add additional undefined check in _handleTxType

* Add additional check for tx.hardfork in _handleTxType

* Add additional check for tx.hardfork in _handleTxType

* Update CHANGELOG

* Handling EIP1559 transactions in outputTransactionFormatter (#4167)

* Handing a null gasPrice and supporting maxFeePerGas and maxPriorityFeePerGas

* Updating gasPrice check

* Revert geth docker version tag

* Add additional EIP-2930 and EIP-1559 tests

* EIP 1559 Debug #2 (#4171)

* Add additional EIP-2930 and EIP-1559 tests

* Update gasPrice to geth default minimum

* Replace hex number with number string

* Add test skip if using Ganache

* Add done function to ganache skip

* Add done function to ganache skip

* Update gasPrice params

* Bump gasPrice to Geth default

* Bump docker geth version to stable

* Gas price type number for 1 Gwei

* gasPrice type and backfills timeout change

* gasPrice type and test acct creation

* added nonce for geth auto nonce issue, removed auto acct creation

* Remove redundant London test. Add gasLimit field to London test

* Add validation for tx.maxPriorityFeePerGas and tx.maxFeePerGas

* Add additional 1559 tests

Co-authored-by: jdevcs <[email protected]>
Co-authored-by: jdevcs <[email protected]>

* Update error message

Co-authored-by: Gregory Markou <[email protected]>

* Update error message

Co-authored-by: Gregory Markou <[email protected]>

* Update use of tx.type

* Replace hardfork strings with enum

* Type check refactors for _handleTxPricing

* Resolve tx.gasPrice if set and tx.type < 0x2 in _handleTxPricing

* Fix _handleTxType logic

Co-authored-by: Gregory Markou <[email protected]>
Co-authored-by: Cory Smith <[email protected]>
Co-authored-by: jdevcs <[email protected]>
Co-authored-by: jdevcs <[email protected]>
mpetrunic added a commit that referenced this issue Jun 6, 2023
Signed-off-by: Marin Petrunic <[email protected]>
mpetrunic added a commit that referenced this issue Jun 7, 2023
Signed-off-by: Marin Petrunic <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants