This repository was archived by the owner on Mar 5, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
EventLog.removed has not been typed #4747
Comments
Thanks @hellowodl for reaching to us with the issue. We would encourage if you create a pull request for it, or we will plan it further considering our capacity. |
samlaf
added a commit
to samlaf/web3.js
that referenced
this issue
Mar 21, 2022
I also need |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. If you believe this was a mistake, please comment. |
jdevcs
added a commit
that referenced
this issue
Oct 28, 2022
* Add `removed` property to `Log` type Fixes #4747 (comment) * Update CHANGELOG.md added this upon jdevcs' [request](#4877 (comment)) * Update CHANGELOG.md Co-authored-by: Junaid <[email protected]>
jdevcs
added a commit
that referenced
this issue
Oct 28, 2022
* Add `removed` property to `Log` type Fixes #4747 (comment) * Update CHANGELOG.md added this upon jdevcs' [request](#4877 (comment)) * Update CHANGELOG.md Co-authored-by: Junaid <[email protected]> Co-authored-by: Samuel Laferriere <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Is there an existing issue for this?
Current Behavior
Listening to web3.eth.Contract.events.Event.on('changed', EventLog => {}) returns an EventLog without { removed: boolean }.
Web3's type definitions don't account for
removed
to exist.Expected Behavior
The EventLog on the
changed
event, should return { removed: boolean } as well.According to the documentation
removed
is added to the object, though typescript says otherwise.https://web3js.readthedocs.io/en/v1.2.11/web3-eth-contract.html#contract-events-return
Steps to Reproduce
Not applicable
Web3.js Version
1.7.0
Environment
No response
Anything Else?
No response
The text was updated successfully, but these errors were encountered: