This repository was archived by the owner on Mar 5, 2025. It is now read-only.
decoupled pub/sub and polling paradigms in contract deployment timeout #1414
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frozeman
approved these changes
Mar 13, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the web3-core-method package, there's a mix of ideas when handling contract deployment error. One of pub/sub (you get a block) and one of an interval set (polling every second) which use the same catch and "block timeout". This fix differentiates between polling and pub/sub watching by adding another variable to the checkConfirmation method and a new timeout for polling (15 * BLOCKTIMEOUT) which approximates the time it currently takes to solve BLOCKTIMEOUT blocks.
This fixes #1102 and some of #951.