Skip to content
This repository was archived by the owner on Mar 5, 2025. It is now read-only.

Allow usage in Web browsers without 'unsafe-eval' Content Security Policy rule #1565

Merged
merged 5 commits into from
Sep 5, 2018

Conversation

jonashaag
Copy link
Contributor

No description provided.

@jonashaag jonashaag changed the base branch from develop to 1.0 April 19, 2018 12:31
@jonashaag jonashaag changed the title Allow web3.js without 'unsafe-eval' Content Security Policy rule Allow usage in Web browsers without 'unsafe-eval' Content Security Policy rule Apr 19, 2018
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 85.609% when pulling ac41383 on jonashaag:1.0-csp-fix into c0e727e on ethereum:1.0.

@coveralls
Copy link

coveralls commented Apr 25, 2018

Coverage Status

Coverage decreased (-0.02%) to 83.821% when pulling b140e77 on jonashaag:1.0-csp-fix into 7a034a1 on ethereum:1.0.

@Powersource
Copy link

This works for me, but I had to install lerna too.

@ErikBjare
Copy link

ErikBjare commented Sep 5, 2018

Wait, why isn't this merged? We've been going crazy in our own issue to use npm ci to install from git which totally depends on this issue: SuperuserLabs/thankful#170 (we need npm ci to get reproducible builds, a requirement for Web Extensions published on Mozilla Addons)

Ping @frozeman @nivida

@frozeman
Copy link
Contributor

frozeman commented Sep 5, 2018

Sorry have overseen this. I merged it. It still need testing for build files to run in the browser with this change

@frozeman frozeman merged commit 3649dba into web3:1.0 Sep 5, 2018
nachomazzara pushed a commit to nachomazzara/web3.js that referenced this pull request Jun 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants