This repository was archived by the owner on Mar 5, 2025. It is now read-only.
Fix mosaic_e2e job error when CI run for fork PR #3481
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgewecke
force-pushed
the
verdaccio-gh-actions
branch
from
6525de1 to
d4fe796
Compare
cgewecke
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@ryanio noted on gitter that in #3451 the mosaic_e2e job is erroring CI.
The verdaccio jobs are marked continue-on-error because Lerna refuses to publish when the git head is in a detached state. We can checkout the branch if PR is made in the root repo but we'd need to add logic to pull in branches from an upstream remote to get this to work for PRs from forks.
Job's just error-ing because of a typo, should be fixed with d4fe796