This repository was archived by the owner on Mar 5, 2025. It is now read-only.
Add tests for transactionPollingTimeout #3533
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#3513
Adds some tests to verify the transactionPollingTimeout threshold is configurable for both web3.eth and contract methods and works as expected with geth interval mining.
Adds examples for the method configuration settings to the docs. In #3513 there was uncertainty about how the polling limit should be set since it seemed like it's not working.
(DRAFT: am requesting @miohtama for further review here because these (unsuccessfully) try to reproduce the config failure reported in #3513)Type of change
Checklist:
npm run dtslint
with success and extended the tests and types if necessary.npm run test:unit
with success.npm run test:cov
and my test cases cover all the lines and branches of the added code.npm run build-all
and tested the resulting files fromdist
folder in a browser.CHANGELOG.md
file in the root folder.