This repository was archived by the owner on Mar 5, 2025. It is now read-only.
Closes #3685 - switch websocket package to remove node-gyp #3686
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GregTheGreek
added
Enhancement
|
@alcuadrado Speed increases look good 👍 |
alcuadrado
reviewed
Aug 14, 2020
|
The failing test seems to be a timeout when initializing a docker container that runs geth. Was this happening before? It seems unrelated to this pr's changes. |
This is unrelated. We're looking into it. Separate issue here #3687 |
GregTheGreek
added
the
On Ice
|
I'm going to switch to a fork that is maintained by us. See #3685 for more details |
14 tasks
GregTheGreek
removed
the
On Ice
|
Closing in favour of #3704 |
GregTheGreek
added a commit
that referenced
this pull request
Sep 1, 2020
* Supercedes #3686 * update changelog
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the changes and be sure to follow our Contribution Guidelines.
See #3685 for full details.
This PR switches the websocket library to a temporary fork that removes the need to compile with node-gyp 🎊. The temporary fork is being maintained by Nomic Labs as a part of a larger effort to eradicate
node-gypfrom ethereum.Fixes #3685
Install stats (via github):
This PR: 106.935s
Current master: 146.577s
Difference: ~40s 👀
Type of change
Checklist:
npm run dtslintwith success and extended the tests and types if necessary.npm run test:unitwith success.npm run test:covand my test cases cover all the lines and branches of the added code.npm run buildand testeddist/web3.min.jsin a browser.CHANGELOG.mdfile in the root folder.