-
Notifications
You must be signed in to change notification settings - Fork 5.1k
Conversation
|
Pull Request Test Coverage Report for Build 659139631
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested installing web3 as a dependency using node 15.5.1
, and it works fine. However, installing the devDependencies
with version 15.5.1
is broken, so I think adding the .nvmrc
file with version 14.15.1
makes sense for developers of web3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested it and works for me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs changelog update :)
Your Render PR Server URL is https://web3-js-pr-3817.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c18ir0jjbvm4ohludhe0. |
* Replace hardcoded infura endpoints (#3943) * Replace hardcoded infura endpoints * infura link changelog * WARNING Exposing secrets, rotate infura keys after debugging is finished * Merging geth-dev-assistant updates (#3950) * Bump geth-dev-assistant to 0.1.9 * npm i * bump geth-dev-assistant * Remove logs * use posinstall to do deprecation warnings (#3917) * use posinstall to do deprecation warnings * add to change log * add preinstall warning * remove preinstall * add warnings to bzz and shh package.json Co-authored-by: Wyatt Barnes <[email protected]> * Bump elliptic from 6.5.3 to 6.5.4 in /packages/web3-eth-accounts (#3941) Bumps [elliptic](https://github.com/indutny/elliptic) from 6.5.3 to 6.5.4. - [Release notes](https://github.com/indutny/elliptic/releases) - [Commits](indutny/elliptic@v6.5.3...v6.5.4) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Wyatt Barnes <[email protected]> * Bump elliptic from 6.5.3 to 6.5.4 in /packages/web3-bzz (#3940) * Bump elliptic from 6.5.3 to 6.5.4 in /packages/web3-bzz Bumps [elliptic](https://github.com/indutny/elliptic) from 6.5.3 to 6.5.4. - [Release notes](https://github.com/indutny/elliptic/releases) - [Commits](indutny/elliptic@v6.5.3...v6.5.4) Signed-off-by: dependabot[bot] <[email protected]> * Update CHANGELOG Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Wyatt Barnes <[email protected]> Co-authored-by: Wyatt Barnes <[email protected]> * Bump elliptic from 6.5.3 to 6.5.4 in /packages/web3-core-requestmanager (#3945) * Bump elliptic from 6.5.3 to 6.5.4 in /packages/web3-core-requestmanager Bumps [elliptic](https://github.com/indutny/elliptic) from 6.5.3 to 6.5.4. - [Release notes](https://github.com/indutny/elliptic/releases) - [Commits](indutny/elliptic@v6.5.3...v6.5.4) Signed-off-by: dependabot[bot] <[email protected]> * Update CHANGELOG Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Wyatt Barnes <[email protected]> * add nvmrc file (#3817) * add nvmrc file * Update changelog Co-authored-by: Wyatt Barnes <[email protected]> Co-authored-by: Wyatt Barnes <[email protected]> * Rename tsc to compile (#3957) (#3958) * Change 'tsc' command in scripts & lerna run to 'compile' * Update changelog * Undo incorrect rename * Checking if e2e test is deterministic Co-authored-by: Sam Hodak <[email protected]> Co-authored-by: Sam Hodak <[email protected]> * Debugging failing tests (#3959) (#3960) * Remote node provider edits * remote node provider documentation edits Co-authored-by: smudgil <[email protected]> Co-authored-by: smudgil <[email protected]> * Clarify commitment to semantic versioning (#3961) (#3962) see discussion in the issue #3758 Co-authored-by: LudwikJaniuk <[email protected]> Co-authored-by: LudwikJaniuk <[email protected]> * Feature/web3 eth iban es6 (#3964) (#3965) * Feature/web3 eth iban es6 (#3964) * web3-eth-iban es6 rewrite - replace `var` with `const` and `let` * web3-eth-iban es6 rewrite - replace object prototype with class * web3-eth-iban code style fix Co-authored-by: Loredana <[email protected]> * Update changelog Co-authored-by: Loredana <[email protected]> Co-authored-by: Frankie <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Sam Hodak <[email protected]> Co-authored-by: smudgil <[email protected]> Co-authored-by: LudwikJaniuk <[email protected]> Co-authored-by: Loredana <[email protected]>
currently web3js will not successfully install deps with node version 15~ and npm version 7
please feel free to debate the node version am very willing to change this
or weather we should specify in package.json file