This repository was archived by the owner on Mar 5, 2025. It is now read-only.
Wyatt/eth2 GitHub action #3896
Merged
Wyatt/eth2 GitHub action #3896
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 538076212
💛 - Coveralls |
GregTheGreek
previously approved these changes
Feb 1, 2021
spacesailor24
dismissed stale reviews from frankiebee and GregTheGreek
via
ff0ee29
GregTheGreek
reviewed
Feb 4, 2021
| @@ -135,7 +135,7 @@ it('getValidatorBalances', async () => { | |||
| expect(response[0]).toMatchObject(expectedResponse) | |||
| }) | |||
|
|
|||
| it('getEpochCommittees', async () => { | |||
| xit('getEpochCommittees', async () => { | |||
There was a problem hiding this comment.
can you make an issue so we can address this in the future?
GregTheGreek
reviewed
Feb 4, 2021
| /* Basic Options */ | ||
| // "incremental": true, /* Enable incremental compilation */ | ||
| "target": "esnext", /* Specify ECMAScript target version: 'ES3' (default), 'ES5', 'ES2015', 'ES2016', 'ES2017', 'ES2018', 'ES2019', 'ES2020', or 'ESNEXT'. */ |
There was a problem hiding this comment.
consider targeting a specific version incase future versions are breaking. i.e es2020
There was a problem hiding this comment.
Updated to ES2020
GregTheGreek
approved these changes
Feb 4, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reverted initial merge (#3892) since we have an active RC
This PR needs to be merged after #3885