-
Notifications
You must be signed in to change notification settings - Fork 5.1k
EIP1559 #4155
EIP1559 #4155
Changes from 8 commits
ec47e41
d50f17a
87738b7
059be6d
7b2acdf
bc8a427
5c11080
c53a87e
f963659
3e4fcbe
7681019
3212c05
43a755f
51f030e
3b3efb2
b458b63
1b66314
ad5a22e
4ebd78a
cd490a8
43fc7aa
5c5a517
34e5cf6
72c9898
073be03
1e3d662
2bb8c63
572e416
abbc390
ef39538
494f260
2437073
b3ab709
dc810b3
e7d3833
d9c509a
2a90980
7324eec
d4f1363
f2ca0d8
e0e19f7
c5be542
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
{ | ||
"version": "1.3.6", | ||
"version": "1.4.0-rc.0", | ||
"lerna": "2.0.0", | ||
"command": { | ||
"init": { | ||
|
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this a new method?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorta, this package doesn't make use of the RPC wrappers found in
web3-eth
, instead needed methods are redefined in the package. I added this method to be able to get a block to find thebaseFeePerGas
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You mean we can't leverage the getBlock (also refs blockCall) because it's defined in the
web3-eth
package and not accessible fromweb3-eth-accounts
?In this case don't we have a dependency or at least a DRY issue that could be addressed somehow?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AndreMiras Yes, and we plan to address the problematic architecture in
4.x
(our rewrite), so for now it's just about making the least amount of change to1.x
as possible, to refrain from introducing additional bugs