-
Notifications
You must be signed in to change notification settings - Fork 5.1k
adding effective gas price to transactionreceipt #4694
Conversation
Your Render PR Server URL is https://web3-js-pr-4694.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c7f1n4nh8vl0ij0borhg. |
I think you could add a test here |
I think the only other thing this needs is for the docs to be updated (including the return value in the example) |
…//github.com/ChainSafe/web3.js into 4692/transaction-receipt-effective-gas-price
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just one more suggestion - Awesome job 🚀
@luu-alex Please create a relevant issue for the |
Good work @luu-alex , changes LGTM, |
|
effective gas price and other price values should be a big number. Starting web3.js 1.7.1 you will be unable to get a receipt for the transaction Reason - very big gas price, number overflow |
Description
#4692
Please include a summary of the changes and be sure to follow our Contribution Guidelines.
Type of change
Checklist:
npm run dtslint
with success and extended the tests and types if necessary.npm run test:unit
with success.npm run test:cov
and my test cases cover all the lines and branches of the added code.npm run build
and testeddist/web3.min.js
in a browser.CHANGELOG.md
file in the root folder.