This repository was archived by the owner on Mar 5, 2025. It is now read-only.
Decoding EIP-838 error codes #5434
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://web3js-docs-pr-5434.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-ccgeuusgqg49ca75k98g. |
|
This pull request introduces 1 alert when merging bfa0831 into 7e236d0 - view on LGTM.com new alerts:
|
…-parameters' into feature/4235/eip-838-error-codes
…/ChainSafe/web3.js into feature/4235/eip-838-error-codes
|
This pull request introduces 1 alert when merging 262196e into 7e236d0 - view on LGTM.com new alerts:
|
Muhammad-Altabba
force-pushed
the
feature/4235/eip-838-error-codes
branch
from
fa08a88 to
d15d63f
Compare
Muhammad-Altabba
changed the title
|
The errors in the Pipeline are not related to this MR and they are addressed here: #5456. |
Muhammad-Altabba
requested review from
jdevcs,
avkos and
luu-alex
and removed request for
jdevcs
nikoulai
reviewed
Sep 19, 2022
packages/web3-eth-contract/test/integration/contract_methods_errors.test.ts
Show resolved
Hide resolved
jdevcs
suggested changes
Sep 19, 2022
packages/web3-eth-contract/test/integration/contract_methods_errors.test.ts
Show resolved
Hide resolved
avkos
approved these changes
Sep 19, 2022
jdevcs
approved these changes
Sep 20, 2022
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements the logic and a test case for #(4235). However, another MR will be done to add more tests and further improvements.
Type of change
Checklist for 1.x:
npm run dtslintwith success and extended the tests and types if necessary.npm run test:covand my test cases cover all the lines and branches of the added code.npm run buildwith success.dist/web3.min.jsin a browser.CHANGELOG.mdfile in the root folder.Checklist for 4.x:
yarnsuccessfullyyarn lintsuccessfullyyarn build:websuccessfullyyarn test:unitsuccessfullyyarn test:integrationsuccessfullycompile:contractssuccessfullyCHANGELOG.mdfile in the packages I have edited.