Release/1.8.1

[jdevcs]

Fixed

• Fixed types for getPastEvents (Update index.d.ts #4955) (Update index.d.ts  #5260)
• Fix Log type by adding missing removed property (Add removed property to Log type #4877)

Changed

• Updated dependencies (Update 1.x Dependencies #5529)

[coveralls]

Pull Request Test Coverage Report for Build 3437510650

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

• For more information on this, see Tracking coverage changes with pull request builds.
• To avoid this issue with future PRs, see these Recommended CI Configurations.
• For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• 436 unchanged lines in 7 files lost coverage.
• Overall coverage decreased (-2.3%) to 72.233%

---

Files with Coverage Reduction	New Missed Lines	%
packages/web3-core-requestmanager/src/jsonrpc.js	2	82.76%
packages/web3-core-helpers/src/formatters.js	25	80.8%
packages/web3-core-helpers/src/errors.js	31	4.41%
packages/web3-utils/src/soliditySha3.js	55	5.13%
packages/web3-utils/src/index.js	58	36.89%
packages/web3-utils/src/utils.js	96	13.31%
packages/web3-eth-accounts/src/index.js	169	23.35%

Totals
Change from base Build 3345039541:	-2.3%
Covered Lines:	3414
Relevant Lines:	4445

---

💛 - Coveralls

[jdevcs]

As part of the RC process, following test installations are performed in other projects and running their tests to see if everything.

• installs properly
• builds
• tests pass

(This list will be actively edited)

Project	Desc	Status
oz-test-helpers	Test utils. Subset of their suite is web3 contracts
synthetix	~1000 units

[jdevcs]

@Muhammad-Altabba and @luu-alex , Could you check Synthetix & OZ tests and update table above. Thanks

[luu-alex]

Project	Desc	Status
[oz-test-helpers][1]	Test utils. Subset of their suite is web3 contracts	✅
[synthetix][2]	~1000 units	✅

oz-test-helpers passed with no errors, synthetix tests had no new errors.
looks good

[Muhammad-Altabba]

@Muhammad-Altabba and @luu-alex , Could you check Synthetix & OZ tests and update table above. Thanks

Cloning oz-test-helpers and linking to this version of web3 produced the following new error:

  1) Contract: balance
       current
         returns the current balance of an account as a BN in a specified unit:
     Error: Invalid character
      at assert (/home/maltabba/repos/web3v1.x/node_modules/bn.js/lib/bn.js:6:21)
      at parseBase (/home/maltabba/repos/web3v1.x/node_modules/bn.js/lib/bn.js:274:7)
      at BN._parseBase (/home/maltabba/repos/web3v1.x/node_modules/bn.js/lib/bn.js:298:14)
      at BN.init [as _init] (/home/maltabba/repos/web3v1.x/node_modules/bn.js/lib/bn.js:105:14)
      at new BN (/home/maltabba/repos/web3v1.x/node_modules/bn.js/lib/bn.js:39:12)
      at new BNwrapped (/home/maltabba/repos/web3v1.x/packages/web3-utils/lib/utils.js:480:16)
      at Object.balanceCurrent [as current] (src/balance.js:40:10)
      at processTicksAndRejections (node:internal/process/task_queues:96:5)
      at Context.<anonymous> (test/src/balance.test.js:17:14)

However, there are other 2 errors that are shown with both this RC and the previous versions (checked with 1.8.0 and 1.2.5). Those errors are:

  2) expectRevert
       assertion
         rejects an outOfGas:
     AssertionError: expect.fail()
      at assertFailure (test/helpers/assertFailure.js:9:10)
      at runMicrotasks (<anonymous>)
      at processTicksAndRejections (node:internal/process/task_queues:96:5)
      at Context.<anonymous> (test/src/expectRevert.test.js:123:7)

  3) expectRevert
       outOfGas
         accepts an outOfGas:

      Wrong kind of exception received
      + expected - actual

      -Transaction: 0xafa2b1b036c974b23e8c76ce348a4e17eca272f767490372ae9df5c634823e57 exited with an error (status 0) after consuming all gas.
      -     Please check that the transaction:
      -     - satisfies all conditions set by Solidity `assert` statements.
      -     - has enough gas to execute the full transaction.
      -     - does not trigger an invalid opcode by other means (ex: accessing an array out of bounds).
      +out of gas
      
      at expectException (src/expectRevert.js:20:30)
      at runMicrotasks (<anonymous>)
      at processTicksAndRejections (node:internal/process/task_queues:96:5)
      at Context.<anonymous> (test/src/expectRevert.test.js:153:7)

I am using the last version of Ganache.

@luu-alex Did you face similar issues

[luu-alex]

@Muhammad-Altabba I believe its similar, the contract: balance failing test persists 1.8.0 and 1.8.1 rc and might need investigation next update

Running against openzeppelin tests with 1.8.1 rc:

  253 passing (2m)
  2 failing

  1) Contract: balance
       current
         returns the current balance of an account as a BN in a specified unit:
     Error: Invalid character
      at assert (node_modules/web3-utils/node_modules/bn.js/lib/bn.js:6:21)
      at parseBase (node_modules/web3-utils/node_modules/bn.js/lib/bn.js:274:7)
      at BN._parseBase (node_modules/web3-utils/node_modules/bn.js/lib/bn.js:298:14)
      at BN.init [as _init] (node_modules/web3-utils/node_modules/bn.js/lib/bn.js:105:14)
      at new BN (node_modules/web3-utils/node_modules/bn.js/lib/bn.js:39:12)
      at new BNwrapped (node_modules/web3-utils/lib/utils.js:480:16)
      at Object.balanceCurrent [as current] (src/balance.js:33:10)
      at processTicksAndRejections (node:internal/process/task_queues:96:5)
      at Context.<anonymous> (test/src/balance.test.js:20:19)

  2) expectRevert
       "before each" hook for "rejects if no revert occurs":
     Error: Timeout of 2000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/Users/alexluu/openzeppelin-test-helpers/test/src/expectRevert.test.js)
      at listOnTimeout (node:internal/timers:559:17)
      at processTimers (node:internal/timers:502:7)

Running against 1.8.0 open zeppelin

 274 passing (1m)
  1 failing

  1) Contract: balance
       current
         returns the current balance of an account as a BN in a specified unit:
     Error: Invalid character
      at assert (node_modules/web3-utils/node_modules/bn.js/lib/bn.js:6:21)
      at parseBase (node_modules/web3-utils/node_modules/bn.js/lib/bn.js:274:7)
      at BN._parseBase (node_modules/web3-utils/node_modules/bn.js/lib/bn.js:298:14)
      at BN.init [as _init] (node_modules/web3-utils/node_modules/bn.js/lib/bn.js:105:14)
      at new BN (node_modules/web3-utils/node_modules/bn.js/lib/bn.js:39:12)
      at new BNwrapped (node_modules/web3-utils/lib/utils.js:480:16)
      at Object.balanceCurrent [as current] (src/balance.js:33:10)
      at processTicksAndRejections (node:internal/process/task_queues:96:5)
      at Context.<anonymous> (test/src/balance.test.js:20:19)

[jdevcs]

@Muhammad-Altabba I believe its similar, the contract: balance failing test persists 1.8.0 and 1.8.1 rc and might need investigation next update

These tests should be investigated in next release #5609