This repository was archived by the owner on Mar 5, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
5601 - fix next.js builds on node v16 #5619
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your Render PR Server URL is https://atweb3js-docs-pr-5619.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-cdpbrgpa6gdn18j7slig. |
avkos
suggested changes
Nov 17, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some of the tests are falling. It will be great to fix them
Pull Request Test Coverage Report for Build 3516153864Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
1 task
nikoulai
approved these changes
Nov 21, 2022
Muhammad-Altabba
approved these changes
Nov 21, 2022
avkos
approved these changes
Nov 21, 2022
This was referenced Mar 3, 2023
This was referenced Mar 3, 2023
This was referenced Mar 7, 2023
This was referenced Mar 7, 2023
This was referenced Mar 20, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#5601
this PR fixes builds on next.js when being built with node v16, I believe
global.request
was being changed due to a polyfill issue and was giving an errorTypeError: Cannot set property Request of # which has only a getter
and its due torequire('abortcontroller-polyfill/dist/polyfill-patch-fetch')
The solution is to only include
require('abortcontroller-polyfill/dist/polyfill-patch-fetch')
when abortController is not defined globally. I believe next.js provides their own global variables and would run into an error whenRequest
was being polyfilled.Please include a summary of the changes and be sure to follow our Contribution Guidelines.
Type of change
Checklist for 1.x:
npm run dtslint
with success and extended the tests and types if necessary.npm run test:cov
and my test cases cover all the lines and branches of the added code.npm run build
with success.dist/web3.min.js
in a browser.CHANGELOG.md
file in the root folder.Checklist for 4.x:
yarn
successfullyyarn lint
successfullyyarn build:web
successfullyyarn test:unit
successfullyyarn test:integration
successfullycompile:contracts
successfullyCHANGELOG.md
file in the packages I have edited.