-
Notifications
You must be signed in to change notification settings - Fork 5.1k
6075 - update return format #6083
Conversation
Bundle StatsHey there, this message comes from a github action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
Deploying with
|
Latest commit: |
39113f2
|
Status: | ✅ Deploy successful! |
Preview URL: | https://aebff0a1.web3-js-docs.pages.dev |
Branch Preview URL: | https://6075.web3-js-docs.pages.dev |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## 4.x #6083 +/- ##
==========================================
+ Coverage 87.59% 87.62% +0.02%
==========================================
Files 199 199
Lines 7564 7566 +2
Branches 2045 2045
==========================================
+ Hits 6626 6630 +4
+ Misses 938 936 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This addresses only smaller bug inside the issue.
Major one is that response on https://github.com/web3/web3.js/blob/4.x/packages/web3-eth/src/rpc_method_wrappers.ts#L884
is not formatted to string/uint8array but rather raw signature object is returned and propagated
Description
#6075


Updated methods so return of these rpc functions can either be string or uint8array, instead of only just string
Type of change
Checklist:
npm run lint
with success and extended the tests and types if necessary.npm run test:unit
with success.npm run test:coverage
and my test cases cover all the lines and branches of the added code.npm run build
and testeddist/web3.min.js
in a browser.CHANGELOG.md
file in the root folder.