This repository was archived by the owner on Mar 5, 2025. It is now read-only.
Replace ethereumjs-util with @ethereumjs/util #6283
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avkos
requested review from
jdevcs,
luu-alex,
Muhammad-Altabba and
spacesailor24
as code owners
Pull Request Test Coverage Report for Build 5656367750
💛 - Coveralls |
jdevcs
reviewed
Jul 14, 2023
| @@ -106,6 +106,7 @@ | |||
| "bignumber.js": "^9.0.1", | |||
| "bn.js": "^5.2.1", | |||
| "browserify": "^16.5.2", | |||
| "browserify-zlib": "^0.2.0", | |||
There was a problem hiding this comment.
we need this Polyfill otherwise build fails by error
luu-alex
approved these changes
Jul 14, 2023
|
other than junaids comment lgtm |
jdevcs
approved these changes
Jul 17, 2023
Muhammad-Altabba
approved these changes
Jul 17, 2023
test/e2e.method.signing.js
Outdated
| @@ -539,6 +539,7 @@ describe('transaction and message signing [ @E2E ]', function() { | |||
| }); | |||
|
|
|||
| it('eth.accounts.sign', async function(){ | |||
| this.timeout(30000); | |||
There was a problem hiding this comment.
Seems weird to require such a long timeout for a signing call
|
@avkos , before merging tests should be passing: |
This was referenced May 12, 2024
This was referenced May 22, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #6021
Type of change
Checklist:
npm run lintwith success and extended the tests and types if necessary.npm run test:unitwith success.npm run test:coverageand my test cases cover all the lines and branches of the added code.npm run buildand testeddist/web3.min.jsin a browser.CHANGELOG.mdfile in the root folder.