-
Notifications
You must be signed in to change notification settings - Fork 442
Async chunk loading for spigot/paper 1.21.3/1.21.4 #4188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
bukkit-helper-121-3/src/main/java/org/dynmap/bukkit/helper/v121_3/MapChunkCache121_3.java
Outdated
Show resolved
Hide resolved
bukkit-helper-121-3/src/main/java/org/dynmap/bukkit/helper/v121_3/MapChunkCache121_3.java
Outdated
Show resolved
Hide resolved
I loaded this on my server, and it's working fine. Although, I've never had major performance issues, so I can't really compare a before -> after. mspt seemed around the same, still generally low. My server is Spigot 1.21.4, which confirms it works there too (Spigot didn't have async chunk loading before). |
The PR has been updated. I hope all matters have been addressed properly. I have not yet been able to test it myself with paper and hope to do so in the next few days. @jacob1 would be great if you could test it again with spigot. Thanks in advance. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok I tested it on my server. It threw an exception, I gave a fix. With that fix, it works great.
bukkit-helper-121-3/src/main/java/org/dynmap/bukkit/helper/v121_3/MapChunkCache121_3.java
Outdated
Show resolved
Hide resolved
Is there a build artifact of this available anywhere? I'd like to test it on my server on which the latest Dynmap release causes lag. |
It's a bad idea to download jars from random people, but you can easily compile |
I fixed the NPE mentioned by @jacob1 and tested on paper. Should be good to go now. |
Looks promising - thanks!! |
This PR brings back async chunk loading for spigot/paper 1.21.3/1.21.4 requested by #4185.
Basically the impl is described here:
#4164 (comment)
Tested on paper 1.21.4.
Let me know if anything else is needed.