Shady Parts: Parsing and formatting functions #326
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aomarks
force-pushed
the
shady-parts-parsing-formatting
branch
from
dee6d36 to
671373b
Compare
sorvell
requested changes
May 15, 2020
| inner = split[0]; | ||
| outer = split[1]; | ||
| } else { | ||
| continue; |
There was a problem hiding this comment.
When will this happen? If the string is poorly formatted? Add comment.
There was a problem hiding this comment.
Yep, if there are >2 colons. Matches Chrome native behavior. Comment added.
| * parsePartSelector for description of pieces. | ||
| * [0 ][1 ][2 ] [3 ] [4 ] | ||
| */ | ||
| const PART_REGEX = /(.*?)([a-z]+-\w+)([^\s]*?)::part\((.*)?\)(::.*)?/; |
There was a problem hiding this comment.
pseudo-classes are written with a single : so this regex won't catch them.
There was a problem hiding this comment.
Ah yeah, oops. Need to match both pseudo-classes and pseudo-elements, so now it matches ::?.
| test("all components", () => { | ||
| assert.deepEqual( | ||
| shadowParts.parsePartSelector( | ||
| "#parent > my-button.fancy::part(foo bar)::hover" |
There was a problem hiding this comment.
pseudo-classes like hover are written with a single :.
sorvell
approved these changes
May 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Start with some the parsing and formatting functions for shadow parts support in ShadyCSS.
(Note this is merging into the
shady-partsbranch, notmaster).See #306 for design.
Part of #252 and #311.