Skip to content

Block out some element page sections #1415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 13, 2023
Merged

Conversation

justinfagnani
Copy link
Collaborator

Just adds a basic grid for header / sidebar / content and rough not-quite-approximate styling of headers to start to see an overall layout.

Lots of hard-coded values, as we've had so far. All the styling will need a audit when we really start making it look like forthcoming designs.

@justinfagnani justinfagnani requested a review from aomarks January 13, 2023 05:35
@github-actions
Copy link

A live preview of this PR will be available at the URL below and will update on each commit. =
The build takes ~5-10 minutes, and will 404 until finished.

https://pr1415---site-khswqo4xea-wl.a.run.app/

Warning
Until our Cloud Run project is public, only authorized users can view the above URL.
The easiest way to view it authenticated is to run the following proxy command and visit http://localhost:5453

(gcloud beta run services proxy --project=webcomponents-org-test --region=us-west2 --tag=pr1415 --port=5453 site \
& gcloud beta run services proxy --project=webcomponents-org-test --region=us-west2 --tag=pr1415 --port=6453 catalog)

<div id="meta-container">
<span id="package-meta"
>${packageName}<select>
<option>x.x.x</option>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to send version and dist tag info in the page data.

@justinfagnani justinfagnani merged commit 3de0eec into main Jan 13, 2023
@justinfagnani justinfagnani deleted the element-page-sections branch January 13, 2023 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants