-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
fix(webdriver): use undici for requests in Node.js #13852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @christian-bromann could you explain a little bit about why we need another tool to retry? I'd think that we could simply have a solution that catches errors and in case of a timeout, puts it in a queue to retry? |
@erwinheitzman introducing undici is not to fix anything about the retry mechanism. It fixes two regressions we introduced in v9:
The package is very lightweight so I don't think it has any impact on the user. |
ebe8280
to
4cc7302
Compare
eslint-plugin-wdio
@wdio/allure-reporter
@wdio/browser-runner
@wdio/appium-service
@wdio/browserstack-service
@wdio/cli
@wdio/concise-reporter
@wdio/config
@wdio/cucumber-framework
@wdio/dot-reporter
@wdio/firefox-profile-service
@wdio/globals
@wdio/jasmine-framework
@wdio/json-reporter
@wdio/junit-reporter
@wdio/lighthouse-service
@wdio/local-runner
@wdio/logger
@wdio/mocha-framework
@wdio/protocols
@wdio/repl
@wdio/reporter
@wdio/runner
@wdio/sauce-service
@wdio/shared-store-service
@wdio/smoke-test-cjs-service
@wdio/smoke-test-reporter
@wdio/smoke-test-service
@wdio/spec-reporter
@wdio/static-server-service
@wdio/sumologic-reporter
@wdio/testingbot-service
@wdio/types
@wdio/utils
@wdio/webdriver-mock-service
webdriver
webdriverio
commit: |
Proposed changes
This is another attempt to fix the request timeout in
webdriver
by falling back toundici
for making requests in Node.js. This time we will change the interface of theWebdriverRequest
class and provide a Node.js version and a cross platform version using native fetch.This PR introduces the same approach to deliver to different environments, e.g. browser, Node.js, CJS, as Puppeteer does it.
fixes #13778
Types of changes
Checklist
Backport Request
//: # (The current
main
branch is the development branch for WebdriverIO v9. If your change should be released to the current major version of WebdriverIO (v8), please raise another PR with the same changes against thev8
branch.)v9
and doesn't need to be back-ported#XXXXX
Further comments
Reviewers: @webdriverio/project-committers