Skip to content

Allow StringType to serialize stringeable values #302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
theofidry opened this issue Jul 7, 2018 · 1 comment
Closed

Allow StringType to serialize stringeable values #302

theofidry opened this issue Jul 7, 2018 · 1 comment

Comments

@theofidry
Copy link
Contributor

I'm not sure when this was removed, but it has been merged in #210 and should be in 0.11.5+. It's however nowhere to be found in the latest version: https://github.com/webonyx/graphql-php/blob/50dfd3fac2cc566335b1667c7e23b29a86df3846/src/Type/Definition/StringType.php
@vladar
Copy link
Member

vladar commented Jul 7, 2018

That's an issue, I've missed it when reviewed 0.12 PRs. We should restore it. PR is welcome!

theofidry added a commit to theofidry/graphql-php that referenced this issue Jul 7, 2018
@theofidry
Allow stringeable objects to be serialized by StringType
c258109 
Closes webonyx#302
@theofidry theofidry mentioned this issue Jul 7, 2018
Merged
@vladar vladar closed this as completed in c1a62fd Jul 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vladar @theofidry