Skip to content

Add validation rule UniqueEnumValueNames #1000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 3, 2021
Merged

Add validation rule UniqueEnumValueNames #1000

merged 4 commits into from
Nov 3, 2021

Conversation

spawnia
Copy link
Collaborator

@spawnia spawnia commented Nov 2, 2021

@spawnia spawnia force-pushed the unique-enum-value-names branch from 74ca9a3 to 9259132 Compare November 2, 2021 13:39
@spawnia
Copy link
Collaborator Author

spawnia commented Nov 2, 2021

@vhenzl working on this, just need to finish tests

@codecov
Copy link

codecov bot commented Nov 2, 2021 •
edited
Loading

Codecov Report

Merging #1000 (9db3eba) into master (647e2cf) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 9db3eba differs from pull request most recent head 0cc9a47. Consider uploading reports for the commit 0cc9a47 to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1000      +/-   ##
============================================
+ Coverage     94.46%   94.47%   +0.01%     
  Complexity       50       50              
============================================
  Files           118      119       +1     
  Lines          9610     9617       +7     
============================================
+ Hits           9078     9086       +8     
+ Misses          532      531       -1
Impacted Files Coverage Δ
src/Type/SchemaValidationContext.php 94.15% <ø> (+0.02%) ⬆️
src/Utils/SchemaExtender.php 99.01% <100.00%> (-0.02%) ⬇️
src/Validator/DocumentValidator.php 83.33% <100.00%> (+0.14%) ⬆️
src/Validator/Rules/UniqueEnumValueNames.php 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 647e2cf...0cc9a47. Read the comment docs.

@spawnia spawnia force-pushed the unique-enum-value-names branch 2 times, most recently from 66063d6 to 2c0f06d Compare November 2, 2021 16:00
@spawnia spawnia marked this pull request as ready for review November 2, 2021 16:00
@spawnia spawnia force-pushed the unique-enum-value-names branch from 2c0f06d to 9db3eba Compare November 2, 2021 16:12
vhenzl
vhenzl reviewed Nov 2, 2021
View reviewed changes
Copy link
Contributor

@vhenzl vhenzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two suggestions. Looks good to me in general.

@spawnia spawnia merged commit 87baadc into master Nov 3, 2021
@spawnia spawnia deleted the unique-enum-value-names branch November 3, 2021 08:08
@simPod
Copy link
Collaborator

simPod commented Nov 3, 2021

💯 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vhenzl vhenzl vhenzl left review comments

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@spawnia @simPod @vhenzl