Skip to content

chore: remove psalm #1242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 4, 2022
Merged

chore: remove psalm #1242

merged 3 commits into from
Nov 4, 2022

Conversation

simPod
Copy link
Collaborator

@simPod simPod commented Nov 3, 2022

The project got "stale". It helped to resolve some issues when we introduced phpdoc types but it causes another issues. Phpstan matured significantly meanwhile.
I don't see a benefit of keeping it anymore.

@spawnia
Copy link
Collaborator

spawnia commented Nov 4, 2022

I was waiting for you to pick up on the failing analysis, after spending some time fiddling around with the type definitions I really did not feel like investing more time to satisfy psalm was a worthwhile activity. You mentioned that having those broken types is problematic for users of the library who also use psalm, what about them?

I automated class-reference regeneration, you can just revert the file to the latest changes in master and let GitHub actions handle it.

@simPod
Copy link
Collaborator Author

simPod commented Nov 4, 2022

Yup, I noticed it's failing just right now in #1241.

I investigated related failures before, isolated them and opened issues in psalm but it's broken still (no blame on psalm guys). They're parsing docblocks using regex which seems like a way to hell to me 🤷🏾‍♂️.

@simPod simPod force-pushed the psalm branch 2 times, most recently from 792740a to 042ca90 Compare November 4, 2022 09:05
@simPod
Copy link
Collaborator Author

simPod commented Nov 4, 2022

BTW you can ping me next time if there's something I missed and can solve

@simPod simPod force-pushed the psalm branch 2 times, most recently from 22cf050 to d2f9fc0 Compare November 4, 2022 09:07
@simPod simPod requested a review from spawnia November 4, 2022 09:09
@spawnia spawnia merged commit 7dc8968 into webonyx:master Nov 4, 2022
@simPod simPod deleted the psalm branch November 4, 2022 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants