This repository was archived by the owner on Sep 28, 2020. It is now read-only.
pass down source map if it exists #70
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. Ok for the sync/async thing (when I coded this - my first loader - I was like "I don't know what I am doing, so I trust you since you seems pretty confident about that change). Will fix the issue in master (after diner ^^) and then merge and release this as a minor release. |
|
Released as 1.2.0. Thanks for your contribution @yyx990803! |
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR's primary purpose is passing down the input source map to the next chained loader if it exists. Although not a common use case, this is necessary if the code being linted was transformed by another loader before passed to
eslint-loader. (In specific, with vue-loader which extracts the JavaScript from a*.vuefile then passes it througheslint-loader)I also took the liberty to simplify the callback usage: since the
lintfunction is in fact purely synchronous, there is no need to check forthis.async()- simply usingthis.callback()will suffice.Regarding the failed test
When running the test locally, there is one autofix-related test failing before this patch is applied, likely due to ESLint updates since the last release. The post-patch test result is exactly the same, so the failed test should have nothing to do with this patch.