This repository was archived by the owner on May 29, 2019. It is now read-only.
Fix handling of loaders as objects without a query prop #232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Current coverage is 85.84% (diff: 100%)@@ master #232 diff @@
==========================================
Files 4 4
Lines 331 332 +1
Methods 68 68
Messages 0 0
Branches 71 72 +1
==========================================
+ Hits 283 285 +2
+ Misses 48 47 -1
Partials 0 0
|
|
Thanks |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you provide a loader as an object without query config, the entire object currently gets returned from
getLoaderWithQuery()and ends up being stringified as[object Object]in the final loader string generated.